Skip to content

Conversation

@yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Jun 27, 2025

What does the PR do?

Remove shared memory key id from client error response when out-of-memory. The shared memory key can used for malicious exploitation. Update corresponding tests.

Before:
[500] Failed to increase the shared memory pool size for key 'triton_python_backend_shm_region_fb03b647-0083-4d79-826b-894768e8f782' to 1048576 bytes. If you are running Triton inside docker, use '--shm-size' flag to control the shared memory region size. Error: No space left on device
After:
[500] Failed to increase the shared memory pool size to 1048576 bytes. If you are running Triton inside docker, use '--shm-size' flag to control the shared memory region size. Error: No space left on device

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

triton-inference-server/python_backend#403

Where should the reviewer start?

Test plan:

  • L0_backend_python--base

  • CI Pipeline ID:
    30661061

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh self-assigned this Jun 27, 2025
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Jun 27, 2025
@yinggeh yinggeh merged commit cc476d7 into main Jun 30, 2025
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-8348-hide-shm-key branch June 30, 2025 12:56
mc-nv added a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DLIS-8382 PR: test Adding missing tests or correcting existing test TPRD-1628

Development

Successfully merging this pull request may close these issues.

4 participants